-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add play
/explore
method to interactively view 3d image or framestack
#29
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 93.51% 88.01% -5.51%
==========================================
Files 4 6 +2
Lines 108 217 +109
==========================================
+ Hits 101 191 +90
- Misses 7 26 +19
Continue to review full report at Codecov.
|
6c36887
to
08f5d40
Compare
For the coverage report:
Manually using them locally seems pretty nice. So I'll say this PR is ready, I'll update the README and then merge it. |
I just noticed that in the example gifs, vscode appears to be creating a new plot per frame? Does it retain the old plots? That would be bad for memory usage |
Unfortunately yes, I can't find a way to refresh on the same plot. Do you have any ideas? (I use |
play
/explore
method to interactively view 3d image or framestack
Rework JuliaImages/ImageInTerminal.jl#43, I've removed the codes related to terminal rendering in this PR to adapt vscode/atom display, I'd prefer to pend the terminal rendering functionality until this is done.
In short words,
play
method provides an interactive alternative to gif view.Hopefully, we could make this implementation the default
Base.show
method for 3d image. I'm not sure of it, so I didn't export the nameplay
yet.Feedback, review, and any kind of features suggestions are welcome.
preview:
Unlike the original PR,
play
method here supports framestack of different image sizes (see the second demo gif).cc: @IanButterworth